Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RC7 Fixes #561

Merged
merged 2 commits into from
May 1, 2020
Merged

RC7 Fixes #561

merged 2 commits into from
May 1, 2020

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Apr 30, 2020 •
edited
Loading

Description

Misc fixes for RC7, notably avoid incorrect content-length when serving record from warcserver->app
When parsing http headers, ensure content-length is updated in case headers are fixed up,
and don't include content-length in the warcserver->app response as its not really needed for this internal transfer.

Motivation and Context

Thanks for debugging by @anjackson!
A likely fix for ukwa/ukwa-pywb#53

Screenshots (if appropriate):

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

ikreymer added 2 commits April 30, 2020 15:06
@ikreymer
misc fixes for 2.4.0rc7:
f2810ef 
- warcserver: when parsing headers to check for redirect, reserialized headers
may be of different length then original, causing warcserver->app response to hang
now adjusting the content-length on the warc record and also not including a fixed
length when serving warcserver->app, possible fix for ukwa/ukwa-pywb#53
- undo change in path resolvers to use os.path.join, just concatenate full_path + filename
- rewrite 'date' -> 'x-orig-archive-date' header to avoid confusion (eg. #548)
- bump version to rc7
@ikreymer
ci: attempt to fix travis build for 27, 35
7eb2286
@ikreymer ikreymer merged commit 7e56ca8 into develop May 1, 2020
@ikreymer ikreymer deleted the rc7 branch June 8, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ikreymer