Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default banner css namespacing #604

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

kaij
Copy link
Contributor

@kaij kaij commented Jan 5, 2021

Description

Added prefix/namespace to css class "mobile" (new: "_wb_mobile") in the default files.

Motivation and Context

As the banner CSS may get injected, this can lead to conflicts with the replayed site if a "mobile" class is used.

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@ikreymer
Copy link
Member

Ah yes, this was intended for use with the framed replay, but can be an issue in frameless mode. Nice find!

@ikreymer ikreymer merged commit 07fb6bb into webrecorder:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants