Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDX sorting: Default list sort is more efficient #609

Merged
merged 1 commit into from
Jan 26, 2021
Merged

CDX sorting: Default list sort is more efficient #609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pywb/indexer/cdxindexer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ def json_encode(obj):


from argparse import ArgumentParser, RawTextHelpFormatter
from bisect import insort

from six import StringIO

Expand Down Expand Up @@ -167,9 +166,10 @@ def write(self, entry, filename):
super(SortedCDXWriter, self).write(entry, filename)
line = self.out.getvalue()
if line:
insort(self.sortlist, line)
self.sortlist.append(line)

def __exit__(self, *args):
self.sortlist.sort()
self.actual_out.write(''.join(self.sortlist))
return False

Expand Down