Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post query json parse fix #711

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Post query json parse fix #711

merged 2 commits into from
Apr 15, 2022

Conversation

ikreymer
Copy link
Member

Description

Fix for #709

Motivation and Context

Updates post-to-get JSON conversion used by internal cdx-indexer. This insures the cdx/cdxj generated by pywb's internal cdx-indexer match the cdxj-indexer

Screenshots (if appropriate):

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

ikreymer added 2 commits April 14, 2022 21:15
@ikreymer
post append query: fix json parsing of lists to be identical to cdxj-…
45b73ad 
…indexer

if json parsing errors occur, log to stderr
fixes #709 in a better way
@ikreymer
update CHANGES.rst
faded6d
@ikreymer ikreymer merged commit 4f44c2e into main Apr 15, 2022
@ikreymer ikreymer deleted the post-query-json-parse-fix branch August 10, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ikreymer