eval rewrite update + latest wombat (3.3.7) #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eval: switch to new eval rewriting which catches global scope rxrewriting: remove lookbehind check so that 'return eval(...)' can be rewritten tests: add additional eval tests bump to 2.6.9
ikreymer
changed the title
tw4l
approved these changes
Sep 19, 2022
Comment on lines
+23
to
+26
| if start == 0: | ||
| return prefix | ||
| if start > 0: | ||
| return x[:start] + prefix |
There was a problem hiding this comment.
This could be simplified to:
if start >= 0:
return x[:start] + prefixsince a [:0] slice of any string is just an empty string. Arguably it's a bit more readable as-is though, so maybe just leave it?
There was a problem hiding this comment.
yeah, was thinking about readability, also ported it from:
https://github.com/webrecorder/wabac.js/blob/main/src/rewrite/jsrewriter.js#L38
to have some parity. so perhaps keep as is for now, unless changed in both places?
omgoo
added a commit
to mirrorweb/pywb
that referenced
this pull request
Sep 30, 2022
dependency: update to latest wombat (3.3.7) (webrecorder#763)
tw4l
pushed a commit
that referenced
this pull request
Oct 19, 2022
eval: switch to new eval rewriting which catches global scope rxrewriting: remove lookbehind check so that 'return eval(...)' can be rewritten tests: add additional eval tests bump to 2.6.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
eval: switch to new eval rewriting which catches global scope rxrewriting: remove lookbehind check so that 'return eval(...)' can be rewritten tests: add additional eval tests
bump to 2.6.9
Motivation and Context
Fixes rewriting of eval statements like
eval("import 'somefile.js'"), using same system as in wabac.js and supported in wombat.js. Updates wombat.js to latest + eval rewriting logic to match wabac.jsScreenshots (if appropriate):
Types of changes
Checklist: