Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ui.logo_home_url as config.yaml option #791

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Conversation

tw4l
Copy link
Member

@tw4l tw4l commented Dec 20, 2022

Description

Adds a new ui.logo_home_url option to config.yaml which allows users to specify a URL that the banner logo should link to. If left unset, the logo will by default not link anywhere.

Motivation and Context

Connected to #790, which describes how the previous behavior sometimes linked to the wrong page, especially for prefixed instances.

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@tw4l tw4l requested a review from ikreymer December 22, 2022 22:10
@tw4l tw4l force-pushed the issue-790-logo-href branch from 0a427af to 7b6f53f Compare January 5, 2023 22:17
@tw4l tw4l force-pushed the issue-790-logo-href branch from 7b6f53f to ecc37d2 Compare January 5, 2023 22:25
@tw4l tw4l merged commit 3d0673e into main Jan 5, 2023
@tw4l tw4l deleted the issue-790-logo-href branch January 5, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants