Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple WARC-Concurrent-To fields #32

Closed
mattfysh opened this issue Aug 19, 2021 · 2 comments · Fixed by #84
Closed

Multiple WARC-Concurrent-To fields #32

mattfysh opened this issue Aug 19, 2021 · 2 comments · Fixed by #84

Comments

@mattfysh
Copy link

Hey Ilya - in the spec a record can have multiple WARC-Concurrent-To fields, e.g.

WARC-Record-ID: <urn:uuid:276ff7fe-efd8-4dfa-972e-606fee81feb7>
WARC-Concurrent-To: <urn:uuid:f22d1d8b-fcf6-4836-9959-7e91c8a2380d>
WARC-Concurrent-To: <urn:uuid:57b684e2-e813-437f-a99f-bf8c31cdb258>

As an exception to the general rule, several WARC-Concurrent-To fields may be repeated within the same WARC record.

https://iipc.github.io/warc-specifications/specifications/warc-format/warc-1.1/#warc-concurrent-to

However the parser is only allowing access to one of them. Is it possible to get record.warcHeader('WARC-Concurrent-To') to return an array of values?

@mattfysh
Copy link
Author

As a workaround I'm using:

class MultiValueMap extends Map {
  set(key, value) {
    let finalValue = value
    if (key === 'WARC-Concurrent-To') {
      const prev = this.get(key) || []
      finalValue = [...prev, value]
    }
    super.set(key, finalValue)
  }
}

const parser = new WARCParser(...)
parser._headersClass = MultiValueMap

ikreymer added a commit that referenced this issue Nov 12, 2024
- add new HeadersMultiMap to support set-cookie, as well as warc-concurrent-to headers with multiple values (store internally as map, convert to array for multi value headers, override iterator)
- update tests to check for multiple warc-concurrent-to
- also ensure multiple Set-Cookie works with case sensitive headers
- fixes #32
ikreymer added a commit that referenced this issue Nov 14, 2024
- add new HeadersMultiMap to support set-cookie, as well as
warc-concurrent-to headers with multiple values (store internally as
map, convert to array for multi value headers, override iterator)
- update tests to check for multiple warc-concurrent-to
- also ensure multiple Set-Cookie works with case sensitive headers
- fixes #32
- ready to support warc-protocol from
iipc/warc-specifications#42
@ikreymer
Copy link
Member

This is finally fixed in the 2.4.0 release, you can use record.warcConcurrentTo() to get an array of WARC-Concurrent-To fields, see: https://github.com/webrecorder/warcio.js/blob/main/test/testSerializer.test.ts#L353 for an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants