-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple WARC-Concurrent-To fields #32
Comments
As a workaround I'm using: class MultiValueMap extends Map {
set(key, value) {
let finalValue = value
if (key === 'WARC-Concurrent-To') {
const prev = this.get(key) || []
finalValue = [...prev, value]
}
super.set(key, finalValue)
}
}
const parser = new WARCParser(...)
parser._headersClass = MultiValueMap |
ikreymer
added a commit
that referenced
this issue
Nov 12, 2024
- add new HeadersMultiMap to support set-cookie, as well as warc-concurrent-to headers with multiple values (store internally as map, convert to array for multi value headers, override iterator) - update tests to check for multiple warc-concurrent-to - also ensure multiple Set-Cookie works with case sensitive headers - fixes #32
ikreymer
added a commit
that referenced
this issue
Nov 14, 2024
- add new HeadersMultiMap to support set-cookie, as well as warc-concurrent-to headers with multiple values (store internally as map, convert to array for multi value headers, override iterator) - update tests to check for multiple warc-concurrent-to - also ensure multiple Set-Cookie works with case sensitive headers - fixes #32 - ready to support warc-protocol from iipc/warc-specifications#42
This is finally fixed in the 2.4.0 release, you can use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey Ilya - in the spec a record can have multiple WARC-Concurrent-To fields, e.g.
https://iipc.github.io/warc-specifications/specifications/warc-format/warc-1.1/#warc-concurrent-to
However the parser is only allowing access to one of them. Is it possible to get
record.warcHeader('WARC-Concurrent-To')
to return an array of values?The text was updated successfully, but these errors were encountered: