One single direction per extmap #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDP has the syntax: a=extmap:<id>/<direction> <uri> The /<direction> part is optional (and rarely seen it in the wild). The current MediaEngine API makes it seem like it's possible to provide many directions for each map (it takes a Vec). This commit changes that sov only single optional direction can be provided. This simplifies internal matching logic and fixes a bug where setting the transceiver direction `inactive`, would (incorrectly) result in no extmaps matching for the m-line.
k0nserv
reviewed
Oct 12, 2022
Codecov ReportBase: 56.80% // Head: 56.79% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #321 +/- ##
==========================================
- Coverage 56.80% 56.79% -0.02%
==========================================
Files 500 500
Lines 47719 47692 -27
Branches 12867 12859 -8
==========================================
- Hits 27107 27086 -21
- Misses 9913 9919 +6
+ Partials 10699 10687 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
k0nserv
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDP has the syntax:
a=extmap:<id>/<direction> <uri>The / part is optional (and rarely seen it in the wild).
The current MediaEngine API makes it seem like it's possible to provide many directions for each map (it takes a Vec). This commit changes that sov only single optional direction can be provided.
This simplifies internal matching logic and fixes a bug where setting the transceiver direction
inactive, would (incorrectly) result in no extmaps matching for the m-line.