Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release minor versions of data, sctp and dtls crates #346

Merged
merged 6 commits into from
Nov 11, 2022

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Nov 10, 2022

No description provided.

@melekes melekes requested a review from k0nserv November 10, 2022 01:43
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 59.00% // Head: 59.01% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4bcffd2) compared to base (4b638fa).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   59.00%   59.01%           
=======================================
  Files         502      502           
  Lines       47893    47893           
  Branches    12912    12920    +8     
=======================================
+ Hits        28261    28264    +3     
  Misses       9966     9966           
+ Partials     9666     9663    -3     
Impacted Files Coverage Δ
...src/track/track_local/track_local_static_sample.rs 40.95% <ø> (ø)
ice/src/agent/agent_gather_test.rs 58.87% <0.00%> (-0.32%) ⬇️
sdp/src/description/session.rs 64.41% <0.00%> (-0.31%) ⬇️
ice/src/agent/agent_vnet_test.rs 67.61% <0.00%> (-0.16%) ⬇️
ice/src/agent/agent_internal.rs 68.82% <0.00%> (ø)
interceptor/src/stats/interceptor.rs 78.89% <0.00%> (+0.47%) ⬆️
rtp/src/header.rs 65.97% <0.00%> (+1.54%) ⬆️
srtp/src/stream.rs 47.61% <0.00%> (+2.38%) ⬆️
interceptor/src/stream_reader.rs 42.85% <0.00%> (+14.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@melekes
Copy link
Contributor Author

melekes commented Nov 10, 2022

https://github.com/webrtc-rs/webrtc/actions/runs/3433764437/jobs/5724602376 fails with Rust 1.67, but it passes for me locally with Rust 1.64. not sure what's happening there.

UPD: found related issue rust-lang/rust#83085

@melekes melekes self-assigned this Nov 10, 2022
sctp/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@k0nserv k0nserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only concern I have is ensuring that things work with an older version of webrtc-rs i.e. 0.5.1 instead of what's in master. Can you verify?

@melekes
Copy link
Contributor Author

melekes commented Nov 11, 2022

Can you verify?

verified. all good 👍

@melekes melekes merged commit 242db9d into master Nov 11, 2022
@melekes melekes deleted the release/data-sctp-and-dtls-crates branch November 11, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants