updating the throughput calculation in data_channel_flow_control #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he actual throughput of the last loop.
|
I have the impression that the deadlock is happening because the requestor and responder are sharing the same tokio runtime. When I modified the offer/answer example to simulate the data_channel_flow_control but using 2 separate processes the deadlock did not materialize. |
rainliu
approved these changes
Mar 13, 2025
|
@rainliu Thanks for reviewing it. Do you need more input from me before merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looking into #101 and it seems that there is a deadlock (tested on M1 chip) where the write_loop or read_loop randomly blocks indefinitely. The way the throughput is calculated is that it reports a degrading performance.
The actual throughput is not degrading but 0. This PR updates the code to report the throughput of every loop iteration independently.
