Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cargo fmt error #7

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Fix cargo fmt error #7

merged 1 commit into from
Nov 1, 2020

Conversation

TaKO8Ki
Copy link
Contributor

@TaKO8Ki TaKO8Ki commented Nov 1, 2020 •
edited
Loading

closes #5

reference: rust-lang/rustfmt#3666

@TaKO8Ki TaKO8Ki force-pushed the fix-cargo-fmt-error branch 3 times, most recently from 2e0b48b to 4fe032d Compare November 1, 2020 05:34
@TaKO8Ki TaKO8Ki changed the title [WIP] Fix fmt error [WIP] Fix cargo fmt error Nov 1, 2020
@TaKO8Ki TaKO8Ki changed the title [WIP] Fix cargo fmt error Fix cargo fmt error Nov 1, 2020
@TaKO8Ki TaKO8Ki marked this pull request as ready for review November 1, 2020 06:30
@TaKO8Ki
Copy link
Contributor Author

TaKO8Ki commented Nov 1, 2020 •
edited
Loading

@rainliu
I'm ready for your review!

@rainliu
Copy link
Member

rainliu commented Nov 1, 2020

thanks for the fix.

@rainliu rainliu merged commit 7009a48 into webrtc-rs:master Nov 1, 2020
@rainliu
Copy link
Member

rainliu commented Nov 1, 2020 •
edited
Loading

looks like still failure. Have to revert it.

@rainliu rainliu mentioned this pull request Nov 1, 2020
Merged
@TaKO8Ki
Copy link
Contributor Author

TaKO8Ki commented Nov 1, 2020 •
edited
Loading

@rainliu
I don't think this failure has anything to do with #5.
cargo fmt works well.
https://github.com/webrtc-rs/webrtc/runs/1337796325?check_suite_focus=true

Diff in /home/runner/work/webrtc/webrtc/dtls/src/state.rs at line 1:

@rainliu
Copy link
Member

rainliu commented Nov 1, 2020

sorry, my fault. I just removed state.rs to get cargo fmt pass.

@TaKO8Ki
Copy link
Contributor Author

TaKO8Ki commented Nov 1, 2020

@rainliu
Thank you!

@TaKO8Ki
Copy link
Contributor Author

TaKO8Ki commented Nov 1, 2020

@rainliu
Should I reopen my pull request?

@rainliu
Copy link
Member

rainliu commented Nov 1, 2020

no need, I put your changes in the latest commit.

@TaKO8Ki TaKO8Ki deleted the fix-cargo-fmt-error branch November 1, 2020 16:54
algesten pushed a commit that referenced this pull request Aug 23, 2022
Merge pull request #7 from webrtc-rs/bytes_refactoring
3ec07e8 
Bytes refactoring
algesten pushed a commit that referenced this pull request Aug 23, 2022
Merge pull request #7 from chertov/add-vnet-feature
21e5c19 
add vnet cargo feature
algesten pushed a commit that referenced this pull request Aug 23, 2022
Merge pull request #7 from u-03c9/main
3fffe97 
Fix some warnings
algesten pushed a commit that referenced this pull request Aug 23, 2022
Merge pull request #7 from algesten/close
744ac18 
close util::Conn connection on .close()
algesten pushed a commit that referenced this pull request Aug 23, 2022
Merge pull request #7 from legion-labs/main
40709f9 
Moved checksum check sooner in the parsing for faster failures
algesten pushed a commit that referenced this pull request Aug 23, 2022
Merge pull request #7 from algesten/anyhow
0edd955 
Refactor out use of anyhow
algesten pushed a commit that referenced this pull request Aug 23, 2022
@melekes
add PollDataChannel::poll_write_vectored (#7)
c0300da 
and PollDataChannel::set_read_buf_capacity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix Github Actions's fmt --all -- --check
2 participants
@TaKO8Ki @rainliu