use raw pointer to uint8_t memory instead of custom "portable" string… #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… class that corrupts zero bytes in binary data.
pwinter1991
pushed a commit
to pwinter1991/flutter-webrtc
that referenced
this pull request
May 5, 2022
…nt between binary or text data also the portable string class introduced corruption if used with binary data containing zero bytes. Updated library see github.com/webrtc-sdk/libwebrtc/pull/21
cloudwebrtc
approved these changes
May 16, 2022
|
LGTM |
cloudwebrtc
pushed a commit
to flutter-webrtc/flutter-webrtc
that referenced
this pull request
May 16, 2022
…nt between binary or text data also the portable string class introduced corruption if used with binary data containing zero bytes. Updated library see github.com/webrtc-sdk/libwebrtc/pull/21 (#935) Co-authored-by: Patrick Winter <patrick.winter@zuehlke.com>
hieplee2997
pushed a commit
to hieplee2997/flutter-webrtc
that referenced
this pull request
Jun 2, 2022
…nt between binary or text data also the portable string class introduced corruption if used with binary data containing zero bytes. Updated library see github.com/webrtc-sdk/libwebrtc/pull/21 (flutter-webrtc#935) Co-authored-by: Patrick Winter <patrick.winter@zuehlke.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to flutter-webrtc/flutter-webrtc#908 the current implementation does not handle binary data correctly if it contains zero or "null" bytes as the string class that is used in the interface doesn't care for this type of data and shouldn't care for that.
I replaced the interface with a raw pointer instead of e.g. a std::vector<uint8_t> to avoid dll boundary issues.