Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Adapter types in PeerConnectionFactory Options for Android #78

Conversation

MohamedRisaldarTA
Copy link
Contributor

@MohamedRisaldarTA MohamedRisaldarTA commented Jun 26, 2023

With this change, It is easy to set "networkIgnoreMask" on Android.
It's easy on iOS, so no change needed.
Will resolve #77.

@MohamedRisaldarTA MohamedRisaldarTA changed the title Exposing Adapter types in PeerConnectionFactory for Android Expose Adapter types in PeerConnectionFactory for Android Jun 26, 2023
@MohamedRisaldarTA MohamedRisaldarTA changed the title Expose Adapter types in PeerConnectionFactory for Android Expose Adapter types in PeerConnectionFactory Options for Android Jun 26, 2023
Copy link
Member

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cloudwebrtc cloudwebrtc merged commit f190c59 into webrtc-sdk:m104_release Jul 3, 2023
cloudwebrtc pushed a commit that referenced this pull request Jul 13, 2023
Start/Stop receiving stream method for VideoTrack (#25)

Properly remove observer upon deconstruction (#26)

feat: Expose setCodecPreferences/getCapabilities for android. (#61)

fix: add WrappedVideoDecoderFactory.java. (#74)

Exposing Adapter types in PeerConnectionFactory (#78)

Co-authored-by: davidliu <davidliu@deviange.net>
Co-authored-by: Mohamed Risaldar UT <73091075+MohamedRisaldarTA@users.noreply.github.com>
@PonyPC
Copy link

PonyPC commented Oct 28, 2023

Does it support Windows? Because under Windows, libwebrtc never connects to 127.0.0.1 TURN server.

@MohamedRisaldarTA
Copy link
Contributor Author

Does it support Windows? Because under Windows, libwebrtc never connects to 127.0.0.1 TURN server.

Not sure about windows / linux now.
I haven't started integrating into windows / linux applications yet.
But, I think you can find it easily by reading those code / trying to use it. (I believe it should be supported, but can't confirm without checking it).

@PonyPC
Copy link

PonyPC commented Dec 6, 2023

#105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants