This repository has been archived by the owner on May 13, 2024. It is now read-only.
fix sdes loopback more #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvestrand
reviewed
May 5, 2020
src/web_app/js/loopback.js
Outdated
| loopbackAnswer = loopbackAnswer | ||
| .replace(/a=crypto:0 AES_CM_128_HMAC_SHA1_32\sinline:.{44}/, ''); | ||
| .replace(/a=crypto:1 .*/, '') | ||
| .replace(/a=crypto:2 .*/, ''); |
There was a problem hiding this comment.
should this be .replace(/a=crypto:[1-9]+ .*/g, '')?
are we guaranteed that the first crypto algo is always OK to use?
There was a problem hiding this comment.
I think we are but this is sdes and it seems like chrome might even not be compliant in not handling multiple a=crypto in an answer.
Updated
until #312 gets done this works around https://bugs.chromium.org/p/chromium/issues/detail?id=1077740
|
lint failure is... meh but too hard to fix. This is unlikely a regression from this change but please use 👀 to double check |
jackzelenkin
approved these changes
Jun 16, 2020
alvestrand
approved these changes
Jun 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
until #312 gets done this works around
https://bugs.chromium.org/p/chromium/issues/detail?id=1077740