Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

On not finding iceserver #662

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions setup.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
These are the steps to setup our personal environment for development
1. Run our docker apprtc:1.0 with following CLI:
docker run --network host --rm -it -v <local_path_to_this_apprtc_repo>:/root/apprtc <apprtc-image-name>:1.0 bash
2. On docker terminal run following commands:
a. cd /root/apprtc
b. npm install
c. pip install -r requirements.txt
d. grunt build
3. With above steps you have apprtc code is built and ready to on docker server with following CLI:
a. cd /root/apprtc
b. dev_appserver.py ./out/app_engine
4. You can open <local)path_to_this_apprtc_repo> in your preferred IDE to browse through javascript code in src/webapp/js folder.
5. Get started with read of README in js directory.

--update this setup.txt as required--
6 changes: 3 additions & 3 deletions src/web_app/js/call.js
Original file line number Diff line number Diff line change
Expand Up @@ -400,11 +400,11 @@ Call.prototype.maybeGetIceServers_ = function() {
this.params_.peerConnectionConfig.iceServers =
servers.concat(iceServers);
}.bind(this)).catch(function(error) {
if (this.onstatusmessage) {
if (this.onstatusmessage) { //How this becomes true
// Error retrieving ICE servers.
var subject =
encodeURIComponent('AppRTC demo ICE servers not working');
this.onstatusmessage(
encodeURIComponent('AppRTC demo ICE servers not working'); //what is the utility of this variable
this.onstatusmessage( // How this message gets activated
'No TURN server; unlikely that media will traverse networks. ' +
'If this persists please ' +
'<a href="mailto:discuss-webrtc@googlegroups.com?' +
Expand Down
5 changes: 3 additions & 2 deletions src/web_app/js/peerconnectionclient.js
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,8 @@ PeerConnectionClient.prototype.setLocalSdpAndNotify_ =
sessionDescription.sdp,
this.params_);
this.pc_.setLocalDescription(sessionDescription)
.then(trace.bind(null, 'Set session description success.'))
.then(trace.bind(null, '' +
'Set session description success.'))
.catch(this.onError_.bind(this, 'setLocalDescription'));

if (this.onsignalingmessage) {
Expand Down Expand Up @@ -331,7 +332,7 @@ PeerConnectionClient.prototype.onSignalingStateChanged_ = function() {
if (!this.pc_) {
return;
}
trace('Signaling state changed to: ' + this.pc_.signalingState);
trace(' Signaling state changed to: ' + this.pc_.signalingState);

if (this.onsignalingstatechange) {
this.onsignalingstatechange();
Expand Down