-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update insertable streams section to WebRTC Encoded transforms #1620
Comments
Unfortunately these API changes don't have consensus; in particular, the Chromium team has not agreed that spinning up a worker should be a requirement for using encoded transforms. In particular see w3c/webrtc-encoded-transform#105 and w3c/webrtc-encoded-transform#89. This has led to a situation where the Firefox and Chrome implementations have not converged on a common API. When these samples were written, "localhost:" was treated as a trusted context by Chrome. Has that changed? Please file a separate bug on either the API difference or the need for HTTPS, and let this bug be just about the other - these are two different concerns. |
@alvestrand Thank you very much - why can't we all just get along :-). This is now the bug just related to the API usage. It would perhaps be easy enough to duplicate the "insertable" tree and rewrite the same examples with an encoded transform. |
I believe @youennf has done it for the "encryption" sample - turned out to be relatively easy in that case. Will be more complex here because the "video analyzer" depends on the display (= main thread) being continuously updated on a per-frame basis - but shouldn't be insurmountable. |
Note: If the checkboxes above are not checked (which you do after the issue is posted), the issue will be closed.
Browser affected
Browser name including version: Firefox 119.0a1. Also Chrome, Safari.
Description
Insertable streams samples represent a deprecated API, replaced by https://w3c.github.io/webrtc-encoded-transform/. Those are implemented from FF117
The desired result is that is it is easy to try out these examples and that they reflect the current standards.
The text was updated successfully, but these errors were encountered: