test: replace travis-multirunner with @puppeter/browsers #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fippo
force-pushed
the
bye-travis
branch
10 times, most recently
from
cb5d2cf to
d2996bf
Compare
|
This one turned out to be mean... showing that adapter did not test in the downloaded chrome because CHROME_BIN was already set in the environment. |
following what was done in adapter which is now back to supporting Firefox stable. Also ignore CHROME_BIN environment variable to download the actual Chrome version, see webrtcHacks/adapter#1157
KaptenJansson
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following what was done in adapter in webrtcHacks/adapter#1155 which is now back to supporting Firefox stable