Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add generateCertificate, fixes #41 #158

Merged
merged 3 commits into from
Jan 15, 2016
Merged

add generateCertificate, fixes #41 #158

merged 3 commits into from
Jan 15, 2016

Conversation

fippo
Copy link
Member

@fippo fippo commented Dec 15, 2015

@KaptenJansson @alvestrand
Not sure if I want to do the same for FF... maybe we should just drop support for versions < 38? Trivial to add though. cc @jan-ivar

@KaptenJansson
Copy link
Collaborator

Nice work! ;)

Maybe we should look over all version checks? Not sure what versions we have committed to support, be aware of Firefox ESR though which lags behind for a while, I think it's still 38.

Also having a test for this would be nice, otherwise LGTM.

@alvestrand
Copy link
Contributor

That was quick :-)
Travis' hiccups seem to be a problem with fetching external content.
Should we add a function that throws a "notSupported" error when the function is not present?

@fippo
Copy link
Member Author

fippo commented Dec 15, 2015

@alvestrand code that wants to use it will have to check if that is a function anyway (if anyone is using it at all)

@KaptenJansson
Copy link
Collaborator

Filed #159 WRT to checking versions just to make sure we do not forget.

@fippo
Copy link
Member Author

fippo commented Dec 18, 2015

Is this only available in M49 when setting --enable-experimental-web-platform-features?
Should we do that for beta and canary? I don't want it to be an assumption we make for stable.

@KaptenJansson
Copy link
Collaborator

LGTM

KaptenJansson added a commit that referenced this pull request Jan 15, 2016
@KaptenJansson KaptenJansson merged commit c65810f into webrtcHacks:master Jan 15, 2016
@fippo fippo deleted the generateCertificate branch July 25, 2016 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants