Add autoplay to video tags for all tests #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM Should we change the tests (in particular https://github.com/webrtc/adapter/blob/master/test/test.js#L387-L396) to be potentially-async and maybe listen for the video elements onresize? |
|
ah... now i understand why this kind-of worked. We are waiting for the element to appear which happens in loadedmetadata. Which apparently is called for videos which don't have autoplay. Maybe we should listen for onresize instead? |
|
cross-referencing -- maybe not playing the elements caused https://bugs.chromium.org/p/webrtc/issues/detail?id=4888 ? |
Closed
|
Changed to onresize and it seems to work well. Will do async tests in a separate PR if it fails or goes flaky. |
KaptenJansson
added a commit
that referenced
this pull request
Jan 18, 2016
Add autoplay to video tags for all tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox does not update video.videoHeight and video.videoWidth until the first frame.