Skip to content
This repository was archived by the owner on Sep 22, 2023. It is now read-only.

Parse :86: field as additional information relating to statement #13

Merged
merged 3 commits into from
Feb 29, 2020

Conversation

ndrsn
Copy link
Contributor

@ndrsn ndrsn commented Feb 26, 2020

Fixes issue raised in #12, where an :86: field relating to the statement as a whole was being parsed as relating to a specific transaction.

Note that there was an extraneous space character in the ing-1.mta, which was allowing the test to pass when it should not have.

Fixes issue raised in webschik#12, where an `:86:` field relating to the statement as a whole was being parsed as relating to a specific transaction.
@ndrsn
Copy link
Contributor Author

ndrsn commented Feb 26, 2020

A note regarding the logic: see statement in MT 940 Network Validated Rules:

If field 86 is present in any occurrence of the repetitive sequence, it must be preceded by a field 61

Therefore, if the current transaction already has description set, I believe it would be fair to assume that the next encountered :86: concerns the statement as a whole instead of the transaction.

@webschik webschik merged commit 2e0e070 into webschik:master Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants