Add support for v18 of react and react-dom #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jukben
approved these changes
Oct 14, 2022
|
Thanks for the contribution! Let's merge it – regarding additional changes I'd rewrite it completely see #226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to update a project to use v18 of React and noticed this issue.
I've only updated the expected peer dependency of
reactandreact-domto allow v18, but if other maintainers would like me to bump the actual dependency (and edit the example index for newcreateRootsyntax) as well, I'm more than happy to do so. In my local testing with react and react-dom v18.2.0, this worked the same as before. Thanks!