adds support for filenames with parentheses #21
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
This is a first attempt at this, and it appears to be working fine. The biggest downside here is that I've got it checking for an extension in order to know when to look for a closing parentheses. Therefore, it will fail in the following situations:
There were not any tests to test for scenario 2, so I don't know how important that is (I'm not even sure if it's allowed in the spec...). If we really need it to pass in scenario 2, we'll need to look into matching pairs or recursive regex, neither of which JS supports out of the box.
//cc @s0ph1e