Fixed bug with unspecified protocol in resources on https page. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklagendijk
commented
Apr 20, 2016
marklagendijk
commented
- When a resource link does not have a protocol defined the protocol from the url of the containing page should be used, instead of just choosing 'http'.
- When a resource link does not have a protocol defined the protocol from the url of the containing page should be used, instead of just choosing 'http'.
|
Could you please add unit test for it to test/unit/utils-test.js ? |
|
Done! |
|
LGTM |
aivus
pushed a commit
that referenced
this pull request
Apr 20, 2016
* Fixed bug with unspecified protocol in resources on https page. - When a resource link does not have a protocol defined the protocol from the url of the containing page should be used, instead of just choosing 'http'. * Added unit tests
s0ph1e
pushed a commit
that referenced
this pull request
Apr 20, 2016
…#46) * Fixed bug with unspecified protocol in resources on https page. - When a resource link does not have a protocol defined the protocol from the url of the containing page should be used, instead of just choosing 'http'. * Added unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.