[minor] allow overriding default duplex stream options for createWebSocketStream #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
reviewed
Oct 11, 2019
…tions which by default are set to false
lpinca
reviewed
Oct 11, 2019
lpinca
reviewed
Oct 11, 2019
lpinca
approved these changes
Oct 14, 2019
|
Thank you. |
|
Thanks! |
|
Do you have rough idea when those changes will be published to NPM? Currently using version from #master but would like to plan migration to stable v7.x, thanks! |
|
|
|
Great! Thank you! |
This was referenced Nov 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1640