Add support for Blob
#2229
Add support for Blob
#2229
Conversation
lpinca
force-pushed
the
support/blob
branch
7 times, most recently
from
223c6fc
to
a83321b
Compare
|
@kettanaito I'm still not very happy with this because, other than compatibility with the WHAWG spec, it is pretty much useless. Anyway, here it is. I also didn't run any benchmarks to see the impact on performance. |
| @@ -1030,6 +1031,11 @@ function initAsClient(websocket, address, protocols, options) { | |||
| */ | |||
| function emitErrorAndClose(websocket, err) { | |||
| websocket._readyState = WebSocket.CLOSING; | |||
| // | |||
| // The following assignment is practically useless and is done only for | |||
There was a problem hiding this comment.
Which summarizes the entire change pretty flawlessly. I am still grateful for this consistency! Thank you!
|
Hi there @lpinca, I can't confirm exactly what's wrong here, but I did a minor version bump and this entirely broke our implementation of |
|
@titanism are you are setting |
Closes #2206