Add role check #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* jwt_error_handler was renamed error_handler * jwt_payload_handler was renamed payload_handler Rename was done in 8b6c1f5
If a ressource has a role specified the jwt should have at least this role If a list is specified, the jwt should have one (or several) of this role
Conflicts:
tests/test_jwt.py
tests/conftest.py
jwt_payload_handler was renamed into payload_handler
|
Very nice suite of tests. Merged and published on pypi (https://pypi.org/project/Webstack-Flask-JWT/). Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to restrain specific ressource to specific roles
The role is picked in JWT_ROLE field of identity, if the intersection of allowed roles and roles of the user is not empty the user can access to the ressource.
The default payload_handler doesn't put role into the JWT, a specific handler should be done to server JWT with role (example done into the tests)
My usage is to implements microservices using a JWT not served by python.
The client part is already live and working well in python 2.7.
Tests are ok in 2.7, 3.3 and 3.4