Fix trait not found #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwansinck
approved these changes
May 3, 2023
rvmourik
requested changes
Jun 7, 2023
| use ApiPlatform\Metadata\Util\ClassInfoTrait as MetadataClassInfoTrait; | ||
| use ApiPlatform\Util\ClassInfoTrait as BaseClassInfoTrait; | ||
|
|
||
| if (trait_exists(MetadataClassInfoTrait::class)) { |
There was a problem hiding this comment.
Maybe add some comments which tells what trait is used in 2.x and 3.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception is
Uncaught ReflectionException: Class "ApiPlatform\Util\ClassInfoTrait" not found while loading "Webstack\ApiPlatformExtensionsBundle\EventListener\MeListener"The problem is in api platform 3.1, the trait's namespace changed from
ApiPlatform\Util\ClassInfoTraittoApiPlatform\Metadata\Util\ClassInfoTrait.This PR create a new trait, which require more code, but still provide support for
api-platform/core:3.0. Do we just simply requireapi-platform/core:^3.1and useApiPlatform\Metadata\Util\ClassInfoTraitdirectly?