Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link in XML node causes 500 #4401

Closed
johnsicili opened this issue Nov 11, 2024 · 2 comments · Fixed by #4713
Closed

link in XML node causes 500 #4401

johnsicili opened this issue Nov 11, 2024 · 2 comments · Fixed by #4713
Assignees
@istarkov
Labels
area:components Parametrized code components prio:2 Always look for prio:1 issues first before working on prio:2 type:bug Something isn't working

Comments

@johnsicili
Copy link
Contributor

Add XML page, add link tag, publish, see 500.

https://react.dev/errors/399?args%5B%5D=link

link

Blocker for RSS feed.

Related: #3715

If not a simple fix, maybe we can make P2.
@johnsicili johnsicili added type:bug Something isn't working area:components Parametrized code components prio:1 The most important thing to work on labels Nov 11, 2024
@kof
Copy link
Member

kof commented Nov 11, 2024

seems like react doesn't understand its an xml link tag, not html?

@johnsicili johnsicili added prio:2 Always look for prio:1 issues first before working on prio:2 and removed prio:1 The most important thing to work on labels Jan 2, 2025
@kof kof unassigned istarkov Jan 2, 2025
@istarkov
Copy link
Member

istarkov commented Jan 2, 2025 •
edited
Loading

Modern react assumes that link is a head element and no way I found to render it normally.

The only idea to fix this is to render all xml tags with some "safe" prefix/suffix and then just replace it.

Like render <AAALink>sdsd</AAALink> then do string replace AAA => empty

@istarkov istarkov self-assigned this Jan 4, 2025
@istarkov istarkov mentioned this issue Jan 4, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@istarkov istarkov

Labels
area:components Parametrized code components prio:2 Always look for prio:1 issues first before working on prio:2 type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Sitemap Index - Unexpected Server Error webstudio-is/webstudio
3 participants
@kof @istarkov @johnsicili