Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sitemap Index - Unexpected Server Error #4713

Merged
merged 1 commit into from
Jan 4, 2025
Merged

fix: Sitemap Index - Unexpected Server Error #4713

merged 1 commit into from
Jan 4, 2025

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Jan 4, 2025

Description

closes #4695
Also allow link in xml
closes #4401

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@johnsicili
Copy link
Contributor

Oh nice you did the prefix!

I don't see a vercel deployment to test on though

@istarkov istarkov merged commit 18aa8fd into main Jan 4, 2025
11 checks passed
@istarkov istarkov deleted the xml branch January 4, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sitemap Index - Unexpected Server Error link in XML node causes 500
3 participants