Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add default canonical link #4776

Merged
merged 2 commits into from
Jan 22, 2025
Merged

feat: Add default canonical link #4776

merged 2 commits into from
Jan 22, 2025

Conversation

istarkov
Copy link
Member

Description

  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov requested a review from johnsicili January 22, 2025 18:11
@istarkov istarkov changed the title fear: Add default canonical link feat: Add default canonical link Jan 22, 2025
Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Tested custom domain, staging domain, custom canonical, xml page, and dynamic page. All look good

@istarkov istarkov merged commit 373fb5f into main Jan 22, 2025
27 of 29 checks passed
@istarkov istarkov deleted the head.staging branch January 22, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants