Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix horizontal scrolling in navigator #4813

Merged
merged 1 commit into from
Feb 1, 2025
Merged

fix: fix horizontal scrolling in navigator #4813

merged 1 commit into from
Feb 1, 2025

Conversation

kof
Copy link
Member

@kof kof commented Jan 31, 2025

Description

Navigator will get horizontal scrollbars when necessary.

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from johnsicili January 31, 2025 20:06
Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scrolling via dragging is broken.

Click and hold navigator item
Drag to the upper or lower bounds
See no scroll occur

@kof
Copy link
Member Author

kof commented Feb 1, 2025

Its not broken, we intentionally disabled it because this has led to missclicks in the tight space, also because the scrollbar is very narrow, its almost never that you would want to drag it

@kof kof requested a review from johnsicili February 1, 2025 09:33
@kof kof merged commit f3d7805 into main Feb 1, 2025
15 checks passed
@kof kof deleted the horizontal-scroll branch February 1, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants