Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image #502

Merged
merged 10 commits into from
Nov 25, 2022
Merged

Image #502

merged 10 commits into from
Nov 25, 2022

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Nov 23, 2022 •
edited
Loading

  • - Image optimization component moved into standalone package
  • - generate-arg-types moved into standalone package - one issue with current yarn workspaces "bin" symlinks not created for sub-dependencies  yarnpkg/yarn#4964 (you need to delete root node_modules, then yarn and yarn build to make generate-arg-types to work)
  • - move json into __generated__ folder, (allow import json from generated folders only)
  • - Icons moved all gen into __generated__
  • - css-data generated content moved to __generated__

@vercel
Copy link

vercel bot commented Nov 23, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webstudio-designer ✅ Ready (Inspect) Visit Preview Nov 25, 2022 at 8:24AM (UTC)

@istarkov istarkov marked this pull request as ready for review November 24, 2022 06:52
rpominov
rpominov reviewed Nov 24, 2022
View reviewed changes
Copy link
Contributor

@rpominov rpominov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allow import json from generated folders only

Why do we want this? Why not allow to import json from anywhere?

packages/generate-arg-types/package.json Outdated Show resolved Hide resolved
@istarkov
Copy link
Member Author

istarkov commented Nov 24, 2022 •
edited
Loading

allow import json from generated folders only

Why do we want this? Why not allow to import json from anywhere?

No use-case I can imagine you would want to import hand written json ;)

Next time anyone will generate other json he will see that it doesn’t work until is inside __generated__ folder. So some kind of force to put generated content into __generated__ folders

@rpominov rpominov self-requested a review November 24, 2022 07:38
@istarkov istarkov merged commit 843467a into main Nov 25, 2022
@istarkov istarkov deleted the image branch November 25, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kof kof kof approved these changes

@TrySound TrySound TrySound left review comments

@rpominov rpominov rpominov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@istarkov @kof @rpominov @TrySound