Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deprecated: memcache_connect(): Passing null to parameter #2... #88

Merged

Conversation

remicollet
Copy link
Contributor

Using PHP 8.1.0alpha1

TEST 44/87 [tests/035.phpt]
========DIFF========
     bool(true)
     bool(true)
     string(3) "abc"
005+ 
006+ Deprecated: memcache_connect(): Passing null to parameter #2 ($port) of type int is deprecated in /work/GIT/pecl-and-ext/memcache/tests/035.php on line 18
     bool(true)
========DONE========
FAIL memcache::connect() with unix domain socket [tests/035.phpt] 

With this patch

=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped    :    0
Exts tested     :   63
---------------------------------------------------------------------

Number of tests :   87                78
Tests skipped   :    9 ( 10.3%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    0 (  0.0%) (  0.0%)
Tests passed    :   78 ( 89.7%) (100.0%)
---------------------------------------------------------------------
Time taken      :   13 seconds
=====================================================================

Copy link
Contributor

@thesource93 thesource93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Remi!

@thesource93 thesource93 merged commit f220ea5 into websupport-sk:NON_BLOCKING_IO_php8 Jun 14, 2021
@remicollet remicollet deleted the issue-php81 branch June 14, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants