fix: testing for instanceof TemplateResult #129
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when code is coming from a different module
quarkus
reviewed
Oct 29, 2024
| @@ -98,6 +98,10 @@ const getValue = (value) => { | |||
| case Array.isArray(value): | |||
| return value.map(getValue).join(''); | |||
| case value instanceof TemplateResult: | |||
| // TODO: instanceof is not working when element-js is used in different modules... | |||
There was a problem hiding this comment.
Not to use instanceof maybe?! We could go back to setting some $$__magic_varibales on the classes and check for those.
But there could be another problem. This happens when npm can't hoist element-js and the bundler uses two different versions. If we changed the instanceof check to something else - we could end up with different versions of element-js that are not compatible with each other?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when code is coming from a different module
Needs tests + a real solution and not just some small bandaid...