-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use npm as publishing registry. #24
Conversation
.gitignore
Outdated
.idea | ||
*.iml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukas-schardt I'm not a big fan of these editor specific files in here. I would encourage everyone to put these in a global .gitignore on your computer.
@@ -10,11 +10,6 @@ Simple and lightweight base classes for web components with a beautiful API | |||
|
|||
#### Installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quarkus How should we notify people that are using element-js already? A note in the changelog/release notes should be fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just change the readme.md and document that its now possible to install element-js without a .npmrc file ..
What about the other packages? Will we have to move them all over before we can start installing element-js? |
@eddyloewen I don't think so, only if we are updating the element-js version on the other package. The currently existing GitHub Package should still be usable by the other packages. |
Yes that is true! But if we would update element-js further and I wanted to use a newer version it will only be available on the NPM registry. But thats ok! Eventually we will have to move all the other packages to NPM as well. Rather sooner than later! |
Closes #20 .
Removed the references to the github package registry.
Still TODO: We need to save the NPM publishing token inside the NPM_TOKEN secret. I don't seem to have enough rights.