Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm as publishing registry. #24

Merged
merged 7 commits into from
Feb 25, 2021
Merged

Use npm as publishing registry. #24

merged 7 commits into from
Feb 25, 2021

Conversation

lukas-schardt
Copy link
Collaborator

@lukas-schardt lukas-schardt commented Jan 25, 2021

Closes #20 .

Removed the references to the github package registry.

Still TODO: We need to save the NPM publishing token inside the NPM_TOKEN secret. I don't seem to have enough rights.

.gitignore Outdated
Comment on lines 3 to 4
.idea
*.iml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukas-schardt I'm not a big fan of these editor specific files in here. I would encourage everyone to put these in a global .gitignore on your computer.

@@ -10,11 +10,6 @@ Simple and lightweight base classes for web components with a beautiful API

#### Installation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quarkus How should we notify people that are using element-js already? A note in the changelog/release notes should be fine?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just change the readme.md and document that its now possible to install element-js without a .npmrc file ..

@eddyloewen
Copy link
Contributor

What about the other packages? Will we have to move them all over before we can start installing element-js?
It will probably not be possible to install packages with the same namespace from two different registries - right?

@lukas-schardt
Copy link
Collaborator Author

@eddyloewen I don't think so, only if we are updating the element-js version on the other package. The currently existing GitHub Package should still be usable by the other packages.

@eddyloewen
Copy link
Contributor

@eddyloewen I don't think so, only if we are updating the element-js version on the other package. The currently existing GitHub Package should still be usable by the other packages.

Yes that is true! But if we would update element-js further and I wanted to use a newer version it will only be available on the NPM registry. But thats ok! Eventually we will have to move all the other packages to NPM as well. Rather sooner than later!

@lukas-schardt lukas-schardt merged commit 1596858 into main Feb 25, 2021
@lukas-schardt lukas-schardt deleted the npm-registry branch February 25, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Think about publishing packages to NPM registry instead of GitHub packages
3 participants