Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm safe-buffer #96

Merged
merged 3 commits into from
Jul 19, 2021
Merged

rm safe-buffer #96

merged 3 commits into from
Jul 19, 2021

Conversation

jimmywarting
Copy link
Contributor

part of brave/brave-browser#5490

(Always require latest Buffer module)

@themasch
Copy link
Contributor

Thanks a lot for the pull requests, getting rid of a dependency sounds great!

I am out of the loop with node, what nodejs version do we require for safe-buffer to be not helpful anymore? Do we need a new major release with a new minimum node version requirement to support this?
Also, seems like travis is finally defunct for this repo, I guess someone need to move that to github actions...

@themasch themasch self-assigned this Jul 18, 2021
@jimmywarting
Copy link
Contributor Author

jimmywarting commented Jul 18, 2021

what nodejs version do we require for safe-buffer to be not helpful anymore?

I asked this question also a while back... feross/safe-buffer#24 when you only support v6+ then you don't need it

I guess someone need to move that to github actions...

👍

@jimmywarting
Copy link
Contributor Author

if you like perhaps switch to a ESM only package.

@themasch
Copy link
Contributor

I just merged that adds github actions for running test. Could you please merge those changes in this branch. I ran the test locally with node12, and do not expect any breakage, but just to be safe...here

I asked this question also a while back... feross/safe-buffer#24 when you only support v6+ then you don't need it

okay, thats a long time ago...

@jimmywarting
Copy link
Contributor Author

Could you please merge those changes in this branch

I did, didn't happen so much new stuff...

@themasch themasch merged commit b507db0 into webtorrent:master Jul 19, 2021
@jimmywarting jimmywarting deleted the rm-safe-buffer branch July 19, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants