Playback audio file is no longer working

[Borewit]

What version of WebTorrent Desktop? (See the 'About WebTorrent' menu)
Version 0.19.0 (0.98.21) (64-bit)

What operating system and version?
Microsoft Windows [Version 10.0.16299.192]

What did you do?

1. Downloaded a audio music album
2. Clicked the music album (torrent), went to the file (track) list
3. Clicked one of the tracks in order to play it (tried: FLAC & MP3)

What did you expect to happen?
I would expect:

1. To see the covert art displayed on the background
2. Metadata of the audio track to appear in the center of the window
3. The audio track to play

What actually happened?

1. Window remains black
2. Audio did not play

[Borewit]

I suspect the issue is caused in:

webtorrent-desktop/src/renderer/webtorrent.js

Lines 340 to 346 in b5bbd9b

	musicmetadata(file.createReadStream(), function (err, info) {
	if (err) return console.log('error getting audio metadata for ' + infoHash + ':' + index, err)
	const { artist, album, albumartist, title, year, track, disk, genre } = info
	const importantInfo = { artist, album, albumartist, title, year, track, disk, genre }
	console.log('got audio metadata for %s: %o', file.name, importantInfo)
	ipc.send('wt-audio-metadata', infoHash, index, importantInfo)
	})

Applying pull request #1240 resolves the cover art problem and does play the track, but the meta-data problem remains (...meta-data of the audio track to appear in the center of the window).

I suspect there is an interoperability issue between the torrent stream and the library handling.

Using the music-metadata module it possible, in addition to stream based reading, to use direct file access. If the file has completed downloading, that could be used instead:

function getAudioMetadata (infoHash, index) {
  const torrent = client.get(infoHash)
  const file = torrent.files[index]

  const options = {native: false, skipCovers: true}
  const onMetaData = file.done
        // If completed; use direct file access
        ? mm.parseFile(path.join(torrent.path, file.path), options)
        // otherwise stream
        : mm.parseStream(file.createReadStream(), file.name, options)

  onMetaData
        .then(function (metadata) {
          console.log('got audio metadata for %s: %o', file.name, metadata)
          ipc.send('wt-audio-metadata', infoHash, index, metadata)
        }).catch(function (err) {
          return console.log('error getting audio metadata for ' + infoHash + ':' + index, err)
        })
}

This fixes the meta-data of the audio track to appear in the center of the window if the file is completed:

I know for for a fact that the old musicmetadata module, as used on the master branch, does not properly implement NodeJS streams. I have not been able able to figure out why the mm.parseStream no longer works with the music-metadata. I have a hard capturing breakpoints in the WebTorrent Hidden Window using IntelliJ.

[Borewit]

I think I got the lost issue (torrent-file-stream not working with music-metadata). I suspect it is caused by an error thrown in then-read-stream

    if (!(s instanceof stream.Readable)) {
      throw new Error("Expected an instance of stream.Readable");

because webtorrent is using the readable-stream module.

Bug reported against my own repo Borewit/peek-readable#4

[Borewit]

I manage to play audio tracks using the master branch code.

I guess I made mistake somewhere switching between from my development branch back to the master branch.