-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When player is active, other downloads should temporarily stop #362
Comments
Disagree! At least for me that is not desirable. |
Maybe there could be an option in the preferences window #144 |
Maybe throttle the rest? This really puts more stress on the preferences issue, specially since the goal is to keep it minimal. |
I think a pause all button would be a good feature, would leave the
|
I think we can solve this with a global priority for pieces to download, across all active torrents. While you're streaming, pieces within a few megabytes of where you're currently playing should get top priority. That way, your media should never pause to buffer as long as your internet connection (and the seeders) are fast enough. Pieces that are far ahead of where you're currently playing can have the same priority as other torrents running in the background. @feross thoughts? @ungoldman to your point, I think this could be more elegant than just pausing all other torrents while one is streaming. At the same time you never want to your video to buffer because other torrents are taking up too much bandwidth |
@dcposch This issue isn't really about piece selection priority as much as throttling. Piece selection priority affects what pieces we ask peers for next. Each torrent currently asks as fast as it can, based on the measured connection speeds, always asking for a little bit more data than the peer is currently sending. Each torrent object in WebTorrent is isolated. One torrent object doesn't know anything about another. So, to solve this issue correctly, we need to add per-torrent throttling and a notion of torrent priority to WebTorrent. We can probably devise a balanced solution where priority for the background torrents increases as the foreground torrent builds up a buffer. But this is a non-trivial change. In the meantime, I propose we do the right thing for 99% of users, and that is to make sure streaming works reliably. Steam does this too. When you launch a game, all game downloads pause so the foreground game can use 100% of the available bandwidth. That model makes sense for WebTorrent too. When the active torrent is not fully downloaded, the full bandwidth should be made available to it. Once it completes, the background torrent downloads can resume. Also, if the torrent is already completed when the playback beings, then background torrent downloading should not be interrupted. |
@agree with those who've said it should be a user-specified preference. Nobody likes torrent clients taking basic things like handling bandwidth out of the hands of the user. That said, perhaps something could be done to improve the efficacy of streaming content, for example not all content loads chronologically yet, which hinders smooth streaming. |
@Moscarda Adding user-controlled bandwidth throttling is a planned feature :) |
I'd say it shall rely on how much buffer is available on the active one, but if little, sounds like it makes sense! |
Closing since #840 was merged. 🎉 |
So all download capacity goes to what the user actually wants to see.
The text was updated successfully, but these errors were encountered: