Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tabular nums and fixed width for no jitter on time #1233

Merged
merged 2 commits into from
Sep 1, 2017

Conversation

emilbayes
Copy link
Contributor

@emilbayes emilbayes commented Aug 28, 2017

The width of the video time was making me uncomfortable 😅, so I fixed by having the numbers be tabular and formatting the time with consideration for the total time.

I was unable to run the integration tests on my 2016 12" Macbook.

I guess using tabular nums could be applied a lot of other places in the app, such as download percentage, file sizes etc.

Before Image:

Before

After image (Added 1h to duration for test purpose):

After

Copy link
Member

@DiegoRBaquero DiegoRBaquero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple yet great change.

@emilbayes
Copy link
Contributor Author

Do you want to merge this before it starts conflicting with other changes? 😅

@DiegoRBaquero DiegoRBaquero merged commit a81156b into webtorrent:master Sep 1, 2017
@feross
Copy link
Member

feross commented Apr 20, 2018

This is awesome, sorry it took so long to merge and release 👍

@lock lock bot locked as resolved and limited conversation to collaborators Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants