-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix playing back audio files & reading music metadata #1240
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
8868128
Add audio format information to play screen.
Borewit 83350b3
Add catalognumber in addition of the release label.
Borewit 6aa3a6c
Fix lint errors
Borewit 54e1564
Fix max line length
Borewit 52e16c3
Fix lint error
Borewit c11a86d
Fix max line length
Borewit 0f00985
Eliminated mime dependency
Borewit f56f3c6
Update version of dependency music-metadata to 0.8.8
Borewit 30c9934
Update version of dependency music-metadata to 0.9.0
Borewit bc91cde
Merge branch 'master' into music-metadata
Borewit 0cce110
Fix bug #1320 by update music-metadata.
Borewit ba1f82f
Use direct file access, if the individual file has completed download…
Borewit d5a62cb
Add additional audio extensions: 'aiff', 'ape', 'mp2', 'oga', 'opus',…
Borewit 070d3ff
Update music-metadata dependency to 0.9.2
Borewit 23d37d7
Merge branch 'master' into music-metadata
Borewit 0572f8a
Update music-metadata dependency to 0.9.4.
Borewit e5a64d9
Add comments to metadata media overlay.
Borewit a725726
Fix formatting according 'standard'
Borewit c720f65
Update dependency music-metadata to version 0.9.5
Borewit fce0003
Add audio metadata standalone entries for: year & release information
Borewit 3dcab9e
Fix audio format metadata
Borewit 34463d9
Enforce music-metadata version which is able to deal with bad Ogg files
Borewit 9b74602
Fixed the win32 version of the test-integration/test-audio: updated s…
Borewit bd2fbe6
Pass file length parameter to music-metadata parser.
Borewit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For MP3 files it seems like this promise is not resolved until the whole file is downloaded.
But the ID3 tags are already available.
Forcing
onMetaData
to bemm.parseFile(path.join(torrent.path, file.path), options)
properly loads metadata on tested files.We might need to check how ID3 tags are being read from the file.
I think we could load them before the full file is downloaded, at least on same cases.
Also, we might want to add a loading indication if we need to wait for the whole file to be downloaded to update the metadata.
Probable we can show the file name and an indication that metadata is being loading.
Cheers!