Improve the poster selection for audio/music based torrent #1334
Conversation
aiming to get the cover-art selected as the torrent poster.
- If filename score is equal, pick highest resolution - Search for keyword occurrence in file name
Simplified code a bit.
|
@codealchemist: Alberto, can you please review this one as well? |
|
I'm getting this error: I was able to reproduce with MP3 files only so far. |
|
Latest merge on this branch fixed thee issues I saw before, yay! Properly displaying poster before all metadata was downloaded: Properly displaying poster after metadata was downloaded: Content list background: Torrent list poster looking good: |
|
I was wondering if we should also display the same background on the torrent details view (files list). |
|
Hey @feross, if you agree I think we should merge this one too and then I'll prepare the changelog on another PR. |
There was a problem hiding this comment.
Didn't look through it very thoroughly, but it generally looks good to me.
If you're confident, go ahead and merge it @codealchemist. :)
|
That was probably not a good idea to commit on top of this pull request after the merge. |
Addressing issue #1332