Use class instead of className; use standard html #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of this PR (choojs/hyperx#22) to hyperx, attributes are automatically converted to properties for the few cases where they’re different: class, for, and http-equiv.
| @@ -16,7 +16,7 @@ | |||
| "create-torrent": "^3.22.1", | |||
| "debug": "^2.2.0", | |||
| "drag-drop": "^2.3.1", | |||
| "hyperx": "^1.4.0", | |||
| "hyperx": "feross/hyperx", | |||
|
LGTM |
ungoldman
added a commit
that referenced
this pull request
Mar 5, 2016
Use class instead of className; use standard html
|
Sure. No strong opinion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of this PR (choojs/hyperx#22) to
hyperx, html attributes are automatically converted to properties for the few cases where they’re different:class,for, andhttp-equiv.So, let's change
<div className="">to<div class="">.Also, I changed all the fancy
<div.my-class>to<div class="my-class">so it's just normal html which is easier to understand, I think. It's less succinct, but it's also clearer and matches the rest of the other attributes that will be in the tag.