-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Borewit dependency/update music metadata #1440
Borewit dependency/update music metadata #1440
Conversation
Thanks for all the great work Alberto! I know you worked on retrieving the metadata on partial downloaded file. Recently I added the skipPostHeaders flag to options music-metadata. This avoids search for ID3v1 headers at which appear at the far end of file. Probaly a good idea to acitivate this one for files which are still downloading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing the standard issue
Thanks for reviewing Diego. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As explained, not able to rest run time at the moment. Changes are looking good to me.
@Borewit Thank you dude! Regarding |
After the merge, I can still reproduce the issue. In case of a partial downloaded file, we can not safely assume we have read the metadata. Depending on how much is downloaded, and depending on the audio format, there may be none, some or all of the metadata available. Let's not worry about the post-headers (a term I invented for headers appearing at the end of the audio track, typically ID3v1 header) at this moment. Files with just an ID3v1 header are rare, and if that is the case it will still search for the header of nothing else is found. I guess we need to be a mechanism which updates the metadata mutiple times while downloading, until we got all metadata available.
Which is more or less coming back to issue #1340. |
@Borewit if we can pass a callback to Which torrent are you using? Thanks! |
That is more efficient approach indeed. I have to admit that this is a function I removed from the original module I cloned from. It will result in some challenges with mapping to the common structure, with duplicates and such. It also requires the stream has to be blocked where chunks are not available yet, but that is the way it works with video as well I suppose. |
I don't have any torrents with me, neither I have a very extensive torrent test anywhere else. But it maybe worth to build a good test set. |
I retested and my change on Saw you've been working on other related PRs so I'll take a look there. |
Enhancements continue on #1449. |
That nails the update mechanism. |
Here we can review the update I propose to ensure we always get proper audio metadata.