Toggle the sound notifications #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
mathiasvr
requested changes
Jan 12, 2019
| <Checkbox | ||
| className='control' | ||
| checked={this.props.state.saved.prefs.soundNotifications} | ||
| label={'Activate the notification sounds'} |
There was a problem hiding this comment.
Nitpick: I would prefer 'Enable notification sounds'.
But since it is both interaction sounds and notification sounds, maybe it should simply be 'Enable sounds'?
| @@ -231,6 +250,9 @@ class PreferencesPage extends React.Component { | |||
| {this.setDefaultAppButton()} | |||
| </PreferencesSection> | |||
| {this.setStartupSection()} | |||
| <PreferencesSection title='Miscellaneous'> | |||
There was a problem hiding this comment.
I think we should group the startup and sound options under a 'General' section instead.
There was a problem hiding this comment.
You're right, looks cleaner to me too 👍
mathiasvr
approved these changes
Jan 13, 2019
|
@adriantombu Thanks for the changes! I took the liberty to add some migration handling to your branch as well. Based on the previous feedback I also think it's fine to make this an option. |
trujamal
approved these changes
Mar 5, 2019
trujamal
approved these changes
Mar 5, 2019
|
🎉 Congrats on getting your first pull request landed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the #1067 issue
As the notificaiton sounds seem a bit controversial, I guess the best way to content everybody would be to allow people to chose what they want, hence this little checkbox to toggle the sounds 😃
Personnally, I'm like @rjmill : sometime I need absolute silence, and sometime I need the notifications.
Anyways, I'm open for feedback 👍