Fix hiddenInset (Mac) titlebar style for electron 4 #1596
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bugginess w/ a duplicated title bar on macOS, as part of the upgrade to Electron 4 (#1590):
Before:
After:
Docs about this param: https://electronjs.org/docs/api/frameless-window#hiddeninset
Note about this breaking change introduced in Electron 2.0: https://github.com/electron/electron/blob/master/docs/api/breaking-changes.md#browserwindow-1