Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use builtin WebView #9

Closed
wants to merge 1 commit into from
Closed

Use builtin WebView #9

wants to merge 1 commit into from

Conversation

LinusU
Copy link
Collaborator

@LinusU LinusU commented Sep 4, 2018

Not quite ready yet, need to test it a bit more. Seems like Android <0.57 still have some problems with this, possible the messages sent over postMessage that aren't escaped properly. Might be worth it to just require 0.57 instead of trying to work around it...

when done, it fixes #1, fixes #7, fixes #8

@saulshanabrook
Copy link
Member

Sorry @LinusU I totally missed this! If you are still interested, I would be happy to make you a contributor of this repo and let you publish as you see fit.

@sirpy
Copy link
Collaborator

sirpy commented Sep 11, 2019

@saulshanabrook
@LinusU What's the status on this? did you get it working?
i've tried to mess around with it, replaced webview with react-native-webview
messaging works good.
once I tried to generate a key, it then enters into an importkey loop. for some reason I saw that the serializebinary that parses the result from webview calls importkey

@saulshanabrook
Copy link
Member

@sirpy I don't have time to work on this project at the moment. If you want to help maintain it, I am happy to support you though!

@sirpy
Copy link
Collaborator

sirpy commented Jan 25, 2020

@sirpy I don't have time to work on this project at the moment. If you want to help maintain it, I am happy to support you though!

@saulshanabrook @LinusU
sure i'll be happy to make a PR, if you can explain what i've asked about serializebinary/importkey

@sirpy
Copy link
Collaborator

sirpy commented Feb 12, 2020

main branch contains a working version based on this work.

@sirpy sirpy closed this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solving the getRandomValues problem Use new webview API for react native Verify works on android
3 participants