fix: specify vite as peer dep #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
commented
Feb 11, 2025
| "@vitejs/plugin-basic-ssl": "^1.1.0", | ||
| "@vitejs/plugin-legacy": "^6.0.0", | ||
| "@vitejs/plugin-basic-ssl": "^1.2.0", | ||
| "@vitejs/plugin-legacy": "^6.0.1", |
There was a problem hiding this comment.
technically out of scope but figured why not 🤷♂️
| "@vitejs/plugin-basic-ssl": "^1.1.0", | ||
| "@vitejs/plugin-legacy": "^6.0.0", | ||
| "@vitejs/plugin-basic-ssl": "^1.2.0", | ||
| "@vitejs/plugin-legacy": "^6.0.1", | ||
| "eruda": "^3.4.1", | ||
| "terser": "^5.36.0", |
There was a problem hiding this comment.
curious if terser is needed as an explicit dep?
achou11
commented
Feb 11, 2025
| "devDependencies": { | ||
| "@webxdc/types": "latest", | ||
| "prettier": "latest", | ||
| "typescript": "latest", | ||
| "vite": "latest" | ||
| "vite": "6.1.0" |
There was a problem hiding this comment.
generally better practice to specify a more explicit version range. can revert if not desired though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when creating plugins, you should specify the versions of vite that are compatible with the plugin by declaring it as a peer dependency. doing it as a peer instead of a direct dep is preferred as it allows the end-user to dictate the version of vite that's used in the project. this will also be helpful towards #5
this also:
@vitejs/plugin-basic-sslto the latest version in order to have proper compatibility with vite@6.@vitejs/plugin-legacyto latestthe noted compatible versions of vite that i've set here are kind of arbitrary. not really sure what the ideal is aside from the latest major, but figured that this plugin is very likely compatible with vite@5 as well so it'd be worth allowing that for the sake of easier adoption.EDIT: nevermind, it probably needs to be v6 only since@vitejs/plugin-legacyrequires v6 as a peer dep