-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supports the issues/331 mentioned in points 2, 3, 4 #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lv-z-l
commented
Sep 2, 2024
- Component Object、Array 的 property支持通过 as 明确指定property的类型
- 支持Component 传自定义属性
- Component 当组件无 properties 选项时,xxx未在 data 中声明,this.data.xxx 不报 TS2339 error 的问题
lv-z-l
changed the title
supports the issues/331 mentioned in points 2, 3, 4
feat: supports the issues/331 mentioned in points 2, 3, 4
Sep 2, 2024
lgtm |
Mister-Hope
approved these changes
Sep 2, 2024
SgLy
requested changes
Sep 3, 2024
SgLy
requested changes
Sep 3, 2024
SgLy
approved these changes
Sep 3, 2024
我觉得没必要限制于 Object 跟 Array,Number 跟 String 也可以通过 Component({
properties: {
num: {
type: Number,
value: 0 as 0 | 1
},
str: {
type: String,
value: 'foo' as 'foo' | 'bar'
}
}
}) 可以修改为: - type ArrayOrObject = ArrayConstructor | ObjectConstructor
- type FullPropertyToData<T extends AllFullProperty> = T['type'] extends ArrayOrObject ? unknown extends T['value'] ? ValueType<T['type']> : T['value'] : ValueType<T['type']>
+ type FullPropertyToData<T extends AllFullProperty> = T['type'] extends null | BooleanConstructor ? ValueType<T['type']> : unknown extends T['value'] ? ValueType<T['type']> : T['value'] @lv-z-l @Mister-Hope @SgLy 你们觉得呢? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.