Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: examples maintain #104

Merged
merged 1 commit into from
Dec 23, 2021
Merged

fix: examples maintain #104

merged 1 commit into from
Dec 23, 2021

Conversation

yy1987316
Copy link
Contributor

@yy1987316 yy1987316 commented Dec 13, 2021

examples maintain

  1. fix example imports
  2. start service with using DaemonStart() instead of Start()
  3. correct if conditions return in OnMessage handler
  4. correct code fragment of replying image
  5. add code fragment of replying url link

@yy1987316 yy1987316 requested a review from a team as a code owner December 13, 2021 15:27
@CLAassistant
Copy link

CLAassistant commented Dec 13, 2021

CLA assistant check
All committers have signed the CLA.

@huan
Copy link
Member

huan commented Dec 13, 2021

Wechaty Contributors Nomination

Link to wechaty/PMC#16

Change-Id: Id566d10ce7e11fc4f7e154799ad502a890936f18
@yy1987316
Copy link
Contributor Author

plz let me know if anything blocks this mr from being merged @huan

@dchaofei
Copy link
Collaborator

我测试了下你的 pr, 发送图片会失败

@dchaofei
Copy link
Collaborator

这是 go-wechaty 的 bug,我已经修复 #106

@dchaofei dchaofei merged commit f78b502 into wechaty:master Dec 23, 2021
@dchaofei
Copy link
Collaborator

非常感谢你的 pr,我已经 merge

@huan
Copy link
Member

huan commented Dec 23, 2021

Thank you very much for your contribution!

You are welcome to join Wechaty Contributor Program

1. Join Wechaty Organization

You've invited yy1987316 to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message. (See also: wechaty/PMC#16)

2. Update Your Wechaty Contributor Profile

  1. Please open Contributor Hall of Fame and add yourself to the end of the list, so that other contributors will know you better!
  2. Please add yourself to our Website Contributors by creating a PR and refer to this PR link as well.

3. Join The Contributor Only WeChat Room

We also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested.

Please add @lijiarui wechat: ruirui_0914 and send her this pr link. She will invite you into Wechaty Contributor Room

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants