Users Mapping Optimization #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 19, 2021 10:05
lprintf
commented
Jul 20, 2021
|
It's not easy to debug the profile show problems, and there only leave the last one guesses waitting to verificate. 😂 |
Yes, It is a intent to set profile, can not do in inital bot user. |
|
|
|
We should deal with the avator like #82 . And there is no defficulty. |
lprintf
commented
Jul 21, 2021
Comment on lines
+268
to
+274
| const avatarFile = await wechatyUser.avatar() | ||
| const avatarBuffer = await avatarFile.toBuffer() | ||
| const avatarUrl = await this.appserviceManager.uploadContent( | ||
| avatarBuffer, | ||
| matrixUserId, | ||
| { type: avatarFile.mimeType }, | ||
| ) |
There was a problem hiding this comment.
We can also use the wechat image source url directly.
added 2 commits
July 21, 2021 08:03
|
No other optimization ideas for the time being. |
huan
approved these changes
Jul 22, 2021
This was referenced Jul 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to optimize information show about wechat user, including the case which #66 descripts.